Skip to content

deprecate implicit_returning #6962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zzzeek opened this issue Aug 31, 2021 · 5 comments
Closed

deprecate implicit_returning #6962

zzzeek opened this issue Aug 31, 2021 · 5 comments
Assignees
Labels
bug Something isn't working documentation engine engines, connections, transactions, isolation levels, execution options high priority
Milestone

Comments

@zzzeek
Copy link
Member

zzzeek commented Aug 31, 2021

this flag is only confusing people. it needs to at least emit a warning.

@zzzeek zzzeek added bug Something isn't working documentation high priority engine engines, connections, transactions, isolation levels, execution options labels Aug 31, 2021
@zzzeek zzzeek added this to the 1.4.x milestone Aug 31, 2021
@jvanasco jvanasco self-assigned this Sep 27, 2021
@jvanasco
Copy link
Member

I'm taking this, but have a few questions:

These two are obviously deprecated

  • lib.sqlalchemy.engine.create.create_engine
  • lib.sqlalchemy.engine.default.DefaultDialect.init

However there is a docstring in this; should it be deprecated too? I believe so.

  • lib.sqlalchemy.engine.interfaces.Dialect.doc

This accepts the kwarg too, and I have no idea if it should be deprecated or left intact:

  • lib.sqlalchemy.sql.schema.Table._init

@zzzeek
Copy link
Member Author

zzzeek commented Sep 27, 2021

id like to remove "implicit_returning" from Table also but there might be some weird compat issues for like SQL Server or Oracle, so maybe we'd need to check on that separately

@sqla-tester
Copy link
Collaborator

jonathan vanasco has proposed a fix for this issue in the master branch:

Fixes: #6962 https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/3106

@jvanasco
Copy link
Member

Ok. I'm leaving it on Table for now, but generated a PR to deprecate it elsewhere.

@jvanasco
Copy link
Member

jvanasco commented Nov 4, 2021

Update:

Deprecating:

  • lib.sqlalchemy.engine.create.create_engine

Keeping:

  • lib.sqlalchemy.engine.default.DefaultDialect.init
  • lib.sqlalchemy.engine.interfaces.Dialect.doc
  • lib.sqlalchemy.sql.schema.Table._init

@zzzeek zzzeek modified the milestones: 1.4.x, 2.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation engine engines, connections, transactions, isolation levels, execution options high priority
Projects
None yet
Development

No branches or pull requests

3 participants