Skip to content

Test on Postgres fail because prepared transactions are disabled by default #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CaselIT opened this issue Dec 27, 2019 · 2 comments
Closed

Test on Postgres fail because prepared transactions are disabled by default #5057

CaselIT opened this issue Dec 27, 2019 · 2 comments

Comments

@CaselIT
Copy link
Member

CaselIT commented Dec 27, 2019 •
edited
Loading

While working on #5055 I encountered some error on postgres the type

psycopg2.errors.ObjectNotInPrerequisiteState: prepared transactions are disabled
HINT:  Set max_prepared_transactions to a nonzero value.

It seems that the default on postgres is to set it to 0. https://www.postgresql.org/docs/current/runtime-config-resource.html#GUC-MAX-PREPARED-TRANSACTIONS

I'll open a pr to add a requirement for it, as suggested by #5055 (comment)
@CaselIT CaselIT mentioned this issue Dec 27, 2019
Closed
3 tasks
@sqla-tester
Copy link
Collaborator

Federico Caselli has proposed a fix for this issue in the master branch:

Improve two phase transaction requirement detection for PG https://gerrit.sqlalchemy.org/1632

@sqla-tester
Copy link
Collaborator

Federico Caselli has proposed a fix for this issue in the rel_1_3 branch:

Improve two phase transaction requirement detection for PG https://gerrit.sqlalchemy.org/1633

sqlalchemy-bot pushed a commit that referenced this issue Dec 29, 2019
@CaselIT @zzzeek
Improve two phase transaction requirement detection for PG
ad57843 
Improved detection of two phase transactions requirement for the PostgreSQL
database by testing that max_prepared_transactions is set to a value
greater than 0.  Pull request courtesy Federico Caselli.

Fixes: #5057
Closes: #5059
Pull-request: #5059
Pull-request-sha: c30c3b1

Change-Id: I4360f62eacdf1173172ee24cd05a68e9a448290c
(cherry picked from commit 92fd25f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve two phase transaction requirement detection CaselIT/sqlalchemy
2 participants
@sqla-tester @CaselIT