Michael Bayer (@zzzeek) wrote:

server_version_info() doesn't have a bug here, we need those tokens to be what they are.

the bug here is that you're oddly enough using exactly a 5.0 version that is for some reason sticking a string into the third token. so this is a very unexpected and buggy version string your DB is reporting which we'd have to work around.

Changes by Michael Bayer (@zzzeek):

• changed title from "server_version_info doesn't return tuple of int to" to "anticipate legacy MySQL version info with strings "

Nicolas Bur (@nbur) wrote:

Therefore I'm going to use python 2.7…
Thank you very much

Michael Bayer (@zzzeek) wrote:

Ok should have this fixed for next release though

Nicolas Bur (@nbur) wrote:

Great. Glad to have pointed this out :)

Changes by Michael Bayer (@zzzeek):

• changed milestone from "1.2" to "1.2.x"

OK so looking at other dialects, psycopg2, pymssql, cx_oracle, all of these take server version info and turn into ints for all tokens, non ints are discarded. this is what we should do here. slight doubt this doesn't break anything but I still think we should do it for 1.2.x.

I encountered the above bug today connecting to a legacy MySQL server with SQLAlchemy 1.2.15 (via records):

(Pdb) list
1966                return self.server_version_info
1967
1968        @property
1969        def _supports_cast(self):
1970            return self.server_version_info is None or \
1971 ->             self.server_version_info >= (4, 0, 2)
1972
1973        @reflection.cache
1974        def get_schema_names(self, connection, **kw):
1975            rp = connection.execute("SHOW schemas")
1976            return [r[0] for r in rp]
(Pdb) p self.server_version_info
(4, 0, '24_Debian', '10sarge2', 'log')

Is there an estimated time for fixing this? Thanks.

@blha303 it's tagged "easy" so we usually wait for contributors to pick these up unless the issue is truly urgent. code should be made to remove non-integer tokens, so code at https://github.com/sqlalchemy/sqlalchemy/blob/master/lib/sqlalchemy/dialects/mysql/base.py#L1843 needs to look more like https://github.com/sqlalchemy/sqlalchemy/blob/master/lib/sqlalchemy/dialects/postgresql/base.py#L2446.