Skip to content

sqlite unique constraint reflection w/ dots in names #3495

Closed
@sqlalchemy-bot

Description

@sqlalchemy-bot
Collaborator

Migrated issue, originally created by Michael Bayer (@zzzeek)

likely a bug in the regex we have to use here

diff --git a/lib/sqlalchemy/testing/suite/test_reflection.py b/lib/sqlalchemy/testing/suite/test_reflection.py
index 3edbdeb..ba70d5c 100644
--- a/lib/sqlalchemy/testing/suite/test_reflection.py
+++ b/lib/sqlalchemy/testing/suite/test_reflection.py
@@ -537,6 +537,7 @@ class ComponentReflectionTest(fixtures.TablesTest):
                 {'name': 'unique_a_b_c', 'column_names': ['a', 'b', 'c']},
                 {'name': 'unique_c_a_b', 'column_names': ['c', 'a', 'b']},
                 {'name': 'unique_asc_key', 'column_names': ['asc', 'key']},
+                {'name': 'i.have.dots', 'column_names': ['b']},
             ],
             key=operator.itemgetter('name')
         )

#!

AssertionError: {'column_names': ['b'], 'name': 'i.have.dots'} != {'column_names': [u'b'], 'name': None}

Activity

sqlalchemy-bot

sqlalchemy-bot commented on Jul 21, 2015

@sqlalchemy-bot
CollaboratorAuthor

Michael Bayer (@zzzeek) wrote:

backport to 0.9.10 and also release 0.9.10

sqlalchemy-bot

sqlalchemy-bot commented on Jul 21, 2015

@sqlalchemy-bot
CollaboratorAuthor

Michael Bayer (@zzzeek) wrote:

f39e692

sqlalchemy-bot

sqlalchemy-bot commented on Jul 21, 2015

@sqlalchemy-bot
CollaboratorAuthor

Michael Bayer (@zzzeek) wrote:

(cherry picked from commit f39e692)

Conflicts:
lib/sqlalchemy/dialects/sqlite/base.py

38d220c

sqlalchemy-bot

sqlalchemy-bot commented on Jul 21, 2015

@sqlalchemy-bot
CollaboratorAuthor

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
added this to the 1.0.8 milestone on Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsqlite

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @sqlalchemy-bot

        Issue actions

          sqlite unique constraint reflection w/ dots in names · Issue #3495 · sqlalchemy/sqlalchemy