Michael Bayer (@zzzeek) wrote:

what type does SQL Server 2012 offer for arbitrarily large text that is unicode ? NVARCHAR is a fixed size; unless SQL Server 2012 allows arbitrary-sized NVARCHAR that's not an option.

Changes by Michael Bayer (@zzzeek):

• changed milestone from "0.9.4" to "0.9.5"

Landon Neale (@lneale) wrote:

http://technet.microsoft.com/en-us/library/ms187993.aspx

nvarchar is a variable length type

Michael Bayer (@zzzeek) wrote:

OK so this is TEXT also and they want to use varchar(max).

However, this means that the Text()/ UnicodeText() types just shouldn't be used with SQL Server. You can instead use String()/Unicode(), which will render as "varchar(max)" / "nvarchar(max)" right now if you don't give them a length.

As it stands, changing Text/UnicodeText to spit out (n)varchar(max) seems like it would be pretty backwards incompatible/surprising for existing users.

Michael Bayer (@zzzeek) wrote:

this is going to surprise people so it'll be for 1.0

Changes by Michael Bayer (@zzzeek):

• attached file 3039.patch

Changes by Michael Bayer (@zzzeek):

• removed labels: low priority

Changes by Michael Bayer (@zzzeek):

• changed milestone from "0.9.5" to "1.0"

Michael Bayer (@zzzeek) wrote:

• SQL Server 2012 now recommends VARCHAR(max), NVARCHAR(max),
  VARBINARY(max) for large text/binary types. The MSSQL dialect will
  now respect this based on version detection, as well as the new
  deprecate_large_types flag.
  fixes ntext - sql server #3039

→ c8817e6

Changes by Michael Bayer (@zzzeek):

• changed status to closed