Skip to content

mysqlconnector cannot override settings #2515

Closed
@sqlalchemy-bot

Description

@sqlalchemy-bot
Collaborator

Migrated issue, originally created by Anonymous

In the mysqlconnector, the default setting for raise_on_warnings is set after the url string settings are read. This prevents the user from overriding the default setting if necessary.

Users who do not have '?raise_on_warnings=False' or '?buffered=False' in their url string will not notice any difference.


Attachments: mysqlconnector.patch

Activity

sqlalchemy-bot

sqlalchemy-bot commented on Jun 20, 2012

@sqlalchemy-bot
CollaboratorAuthor

Michael Bayer (@zzzeek) wrote:

thanks

sqlalchemy-bot

sqlalchemy-bot commented on Jun 20, 2012

@sqlalchemy-bot
CollaboratorAuthor

Changes by Michael Bayer (@zzzeek):

  • removed labels: easy
  • set milestone to "0.7.9"
sqlalchemy-bot

sqlalchemy-bot commented on Sep 23, 2012

@sqlalchemy-bot
CollaboratorAuthor

Michael Bayer (@zzzeek) wrote:

this is on hold as the current released and development versions of mysql-connector python are broken and non-functional with SQLAlchemy. See https://answers.launchpad.net/myconnpy/+question/209397 .

sqlalchemy-bot

sqlalchemy-bot commented on Sep 23, 2012

@sqlalchemy-bot
CollaboratorAuthor

Changes by Michael Bayer (@zzzeek):

  • changed milestone from "0.7.9" to "0.x.xx"
sqlalchemy-bot

sqlalchemy-bot commented on Oct 13, 2013

@sqlalchemy-bot
CollaboratorAuthor

Michael Bayer (@zzzeek) wrote:

the defaults just needed to be set correctly:

0cea9fd 0.8

366e74b 0.9

sqlalchemy-bot

sqlalchemy-bot commented on Oct 13, 2013

@sqlalchemy-bot
CollaboratorAuthor

Changes by Michael Bayer (@zzzeek):

  • changed milestone from "0.x.xx" to "0.8.xx"
  • changed status to closed
sqlalchemy-bot

sqlalchemy-bot commented on Jul 9, 2014

@sqlalchemy-bot
CollaboratorAuthor

Michael Bayer (@zzzeek) wrote:

this is wrong. "buffered" and "raise on warning" default to False. No clue why these are defaulitng to True.

sqlalchemy-bot

sqlalchemy-bot commented on Jul 9, 2014

@sqlalchemy-bot
CollaboratorAuthor

Changes by Michael Bayer (@zzzeek):

  • changed status to reopened
sqlalchemy-bot

sqlalchemy-bot commented on Jul 9, 2014

@sqlalchemy-bot
CollaboratorAuthor

Changes by Michael Bayer (@zzzeek):

  • edited description
sqlalchemy-bot

sqlalchemy-bot commented on Jul 9, 2014

@sqlalchemy-bot
CollaboratorAuthor

Changes by Michael Bayer (@zzzeek):

  • changed milestone from "0.8.xx" to "1.0"
sqlalchemy-bot

sqlalchemy-bot commented on Jul 9, 2014

@sqlalchemy-bot
CollaboratorAuthor

Michael Bayer (@zzzeek) wrote:

  • Changed the default value of "raise_on_warnings" to False for
    MySQLconnector. This was set at True for some reason. The "buffered"
    flag unfortunately must stay at True as MySQLconnector does not allow
    a cursor to be closed unless all results are fully fetched. fixes mysqlconnector cannot override settings #2515
  • lots of MySQL tests seemed to not be hitting all backends, so we should
    be getting some mysqlconnector failures now

2b85e80

sqlalchemy-bot

sqlalchemy-bot commented on Jul 9, 2014

@sqlalchemy-bot
CollaboratorAuthor

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
added this to the 1.0 milestone on Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @sqlalchemy-bot

        Issue actions

          mysqlconnector cannot override settings · Issue #2515 · sqlalchemy/sqlalchemy