Skip to content

add prefix_with() to query #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sqlalchemy-bot opened this issue Mar 19, 2012 · 8 comments
Closed

add prefix_with() to query #2443

sqlalchemy-bot opened this issue Mar 19, 2012 · 8 comments
Labels
feature orm
Milestone
0.7.7

Comments

@sqlalchemy-bot
Copy link
Collaborator

Migrated issue, originally created by Michael Bayer (@zzzeek)

Attachments: 2443.patch | 2443.2.patch
@sqlalchemy-bot
Copy link
Collaborator Author

Anonymous wrote:

(original author: diana) here's a very naive attempt at this ticket

@sqlalchemy-bot
Copy link
Collaborator Author

Changes by Anonymous:

  • attached file 2443.patch

@sqlalchemy-bot
Copy link
Collaborator Author

Anonymous wrote:

(original author: diana) I wasn't sure if @_generative() needed to be called with something like _no_criterion_condition + mods. I wasn't quite sure about a few things -- diff with care :)

Thanks for letting me try!

@sqlalchemy-bot
Copy link
Collaborator Author

Anonymous wrote:

(original author: diana) think I need to escape this -- didn't test docs

@sqlalchemy-bot
Copy link
Collaborator Author

Changes by Anonymous:

  • attached file 2443.2.patch

@sqlalchemy-bot
Copy link
Collaborator Author

Michael Bayer (@zzzeek) wrote:

looks great to me! just trimmed the tuple addition a bit. 565b5dc thanks !

@sqlalchemy-bot
Copy link
Collaborator Author

Changes by Michael Bayer (@zzzeek):

  • changed status to closed

@sqlalchemy-bot
Copy link
Collaborator Author

Anonymous wrote:

(original author: diana) Replying to zzzeek:

looks great to me! just trimmed the tuple addition a bit. 565b5dc thanks !

ah yes, silly me. thanks!

@sqlalchemy-bot sqlalchemy-bot added this to the 0.7.7 milestone Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature orm
Projects
None yet
Milestone
0.7.7
Development

No branches or pull requests
1 participant
@sqlalchemy-bot